Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent function signature in CDC.cpp #136

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

echtzeit-dev
Copy link

USBAPI.h declares the return type of Serial_::baud() as uint32_t

This causes an error when building the framework with Clang, because it typedefs arm-none-eabi uint32_t to unsigned int and not to unsigned long like gcc-arm-none-eabi.

USBAPI.h declares the return type of Serial_::baud() as `uint32_t`
@CLAassistant
Copy link

CLAassistant commented Mar 15, 2022

CLA assistant check
All committers have signed the CLA.

@facchinm
Copy link
Member

LGTM, thanks! If you could sign the CLA I'll be glad to merge it immediately 🙂

@echtzeit-dev
Copy link
Author

I have 3 more fixes. They are rather small as well. Should I make separate PRs or would you prefer a single one with 3 commits?

@echtzeit-dev
Copy link
Author

FYI: There appears to be lag in the CLA check. I signed it and the page behind link confirms that, but the check here is still pending (even after clicking the recheck link).

@per1234
Copy link
Contributor

per1234 commented Mar 15, 2022

Hi @echtzeit-dev. I don't think it is a lag. The check is done against the user who created the commit. That is @weliveindetail, so it is @weliveindetail who must sign the CLA in order for the check to pass.

Hopefully the check will automatically pass once that has been done. If not, please comment here and we will investigate.

@weliveindetail
Copy link

Thanks for you note @per1234! It worked.

@echtzeit-dev
Copy link
Author

FYI: There appears to be lag in the CLA check. I signed it and the page behind link confirms that, but the check here is still pending (even after clicking the recheck link).

I added them here directly: #136 (commits)

@echtzeit-dev
Copy link
Author

@facchinm Are you still considering to merge this? Otherwise, do you have any questions or change requests? Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants