-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent function signature in CDC.cpp #136
base: master
Are you sure you want to change the base?
Conversation
USBAPI.h declares the return type of Serial_::baud() as `uint32_t`
LGTM, thanks! If you could sign the CLA I'll be glad to merge it immediately 🙂 |
This causes an override mismatch for UARTClass::begin(const uint32_t) in UARTClass.h when compiling with Clang
I have 3 more fixes. They are rather small as well. Should I make separate PRs or would you prefer a single one with 3 commits? |
FYI: There appears to be lag in the CLA check. I signed it and the page behind link confirms that, but the check here is still pending (even after clicking the recheck link). |
Hi @echtzeit-dev. I don't think it is a lag. The check is done against the user who created the commit. That is @weliveindetail, so it is @weliveindetail who must sign the CLA in order for the check to pass. Hopefully the check will automatically pass once that has been done. If not, please comment here and we will investigate. |
Thanks for you note @per1234! It worked. |
I added them here directly: #136 (commits) |
@facchinm Are you still considering to merge this? Otherwise, do you have any questions or change requests? Thx |
USBAPI.h declares the return type of Serial_::baud() as
uint32_t
This causes an error when building the framework with Clang, because it typedefs arm-none-eabi
uint32_t
tounsigned int
and not tounsigned long
like gcc-arm-none-eabi.