Issue - 42 WhisperKit support simulator fixed #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muukii
reviewed
Mar 6, 2024
Sources/WhisperKit/Core/Models.swift
Outdated
| @@ -129,7 +129,7 @@ public struct ModelComputeOptions { | |||
| public var prefillCompute: MLComputeUnits | |||
|
|
|||
| public init( | |||
| melCompute: MLComputeUnits = .cpuAndGPU, | |||
| melCompute: MLComputeUnits = .cpuOnly, | |||
There was a problem hiding this comment.
at least, we should use compiler macro and then use CPU only for simulator.
ZachNagengast
requested changes
Mar 6, 2024
There was a problem hiding this comment.
Yep like @muukii mentioned, we'll want this to be default only for the simulator - see comment suggestion
Here's another example of how it should work https://github.com/huggingface/swift-transformers/pull/46/files
Sources/WhisperKit/Core/Models.swift
Outdated
Comment on lines
132
to
135
| melCompute: MLComputeUnits = .cpuOnly, | ||
| audioEncoderCompute: MLComputeUnits = .cpuAndNeuralEngine, | ||
| textDecoderCompute: MLComputeUnits = .cpuAndNeuralEngine, | ||
| prefillCompute: MLComputeUnits = .cpuOnly |
There was a problem hiding this comment.
Suggested change
| melCompute: MLComputeUnits = .cpuOnly, | |
| audioEncoderCompute: MLComputeUnits = .cpuAndNeuralEngine, | |
| textDecoderCompute: MLComputeUnits = .cpuAndNeuralEngine, | |
| prefillCompute: MLComputeUnits = .cpuOnly | |
| #if targetEnvironment(simulator) | |
| melCompute: MLComputeUnits = .cpuOnly, | |
| audioEncoderCompute: MLComputeUnits = .cpuOnly, | |
| textDecoderCompute: MLComputeUnits = .cpuOnly, | |
| prefillCompute: MLComputeUnits = .cpuOnly | |
| #else | |
| melCompute: MLComputeUnits = .cpuAndGpu, | |
| audioEncoderCompute: MLComputeUnits = .cpuAndNeuralEngine, | |
| textDecoderCompute: MLComputeUnits = .cpuAndNeuralEngine, | |
| prefillCompute: MLComputeUnits = .cpuOnly | |
| #endif |
|
@bharat9806 based on this issue #65 I'd also like to push a fix to this branch and bundle them together, the tests are currently failing - will want to merge with main as well |
ZachNagengast
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42