Update release process to create a separate tag for registry-scanner #1022
Conversation
ishitasequeira
changed the title
ishitasequeira
force-pushed
the
update-release-script
branch
from
57a8807 to
c6ac26a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1022 +/- ##
=======================================
Coverage 62.57% 62.57%
=======================================
Files 15 15
Lines 2250 2250
=======================================
Hits 1408 1408
Misses 753 753
Partials 89 89 ☔ View full report in Codecov by Sentry. |
ishitasequeira
requested review from
jannfis,
chengfang and
pasha-codefresh
as code owners
|
I personally prefer to have the release files contained under registry-scanner itself. I guess pretty soon these 2 will diverge in versions. Then for image-updater, registry-scanner is just another dependency to manage. |
Signed-off-by: Ishita Sequeira <ishiseq29@gmail.com>
Signed-off-by: Ishita Sequeira <ishiseq29@gmail.com>
ishitasequeira
force-pushed
the
update-release-script
branch
from
c6ac26a to
671ea1f
Compare
Signed-off-by: Ishita Sequeira <ishiseq29@gmail.com>
| # Create tag for registry-scanner | ||
| git tag "${NEW_TAG}" | ||
| git push "${REMOTE}" tag "${NEW_TAG}" | ||
|
|
There was a problem hiding this comment.
should we just name this file as create-release.sh since it just creates a release tag, without any PR?
| echo "${TARGET_VERSION}" > VERSION | ||
|
|
||
| # Create tag for registry-scanner | ||
| git tag "${NEW_TAG}" |
There was a problem hiding this comment.
Maybe we can create an annotated tag to include additional information about the tag?
| # - run this script from repo root: ./hack/create-release-pr.sh [REMOTE] | ||
| # - merge the PR | ||
| # It will trigger the release workflow that would create release draft on github | ||
|
|
There was a problem hiding this comment.
this script takes 2 args, so the above comments need updating to reflect that. Also no PR is involved.
| set -o pipefail | ||
|
|
||
| if test "${TARGET_VERSION}" = ""; then | ||
| echo "USAGE: $0 <version>" >&2 |
There was a problem hiding this comment.
the usage should warn about 2 args
There was a problem hiding this comment.
I have kept the remote as an optional parameter defaulting to origin.
Signed-off-by: Ishita Sequeira <ishiseq29@gmail.com>
Signed-off-by: Ishita Sequeira <ishiseq29@gmail.com>
Update release process to create a separate tag for registry-scanner.
Currently, keeping the release version of registry-scanner same as image updater. Let me know if we need to change this version matching for image-updater and registry-scanner.Updated to have separate release of registry-scanner