feat: Support kube 1.32 #21805
Open
feat: Support kube 1.32 #21805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sivchari <shibuuuu5@gmail.com>
Signed-off-by: sivchari <shibuuuu5@gmail.com>
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: sivchari <shibuuuu5@gmail.com>
Signed-off-by: sivchari <shibuuuu5@gmail.com>
Signed-off-by: sivchari <shibuuuu5@gmail.com>
Signed-off-by: sivchari <shibuuuu5@gmail.com>
sivchari
commented
Feb 7, 2025
| @@ -301,41 +300,43 @@ replace ( | |||
| github.com/golang/protobuf => github.com/golang/protobuf v1.5.4 | |||
| github.com/grpc-ecosystem/grpc-gateway => github.com/grpc-ecosystem/grpc-gateway v1.16.0 | |||
|
|
|||
| gituh.com/argoproj/gitops-enine => github.com/sivchari/gitops-engine v0.0.0-20250207011704-28b43ab93d0c | |||
There was a problem hiding this comment.
This line will be deleted when the gitops's PR is merged.
Signed-off-by: sivchari <shibuuuu5@gmail.com>
sivchari
commented
Feb 7, 2025
| @@ -1440,9 +1440,6 @@ func (server *ArgoCDServer) newStaticAssetsHandler() func(http.ResponseWriter, * | |||
| } else { | |||
| if isMainJsBundle(r.URL) { | |||
| cacheControl := "public, max-age=31536000, immutable" | |||
| if !fileRequest { | |||
There was a problem hiding this comment.
After Go1.23, when the response status isn't 200, the some header is deleted.
ref. https://tip.golang.org/doc/go1.23
Signed-off-by: sivchari <shibuuuu5@gmail.com>
sivchari
force-pushed
the
support-kube-1.32
branch
from
bca9b9d to
a8b1f23
Compare
Signed-off-by: sivchari <shibuuuu5@gmail.com>
sivchari
force-pushed
the
support-kube-1.32
branch
from
a8b1f23 to
548a4c0
Compare
Signed-off-by: sivchari <shibuuuu5@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21805 +/- ##
==========================================
+ Coverage 55.67% 55.69% +0.01%
==========================================
Files 339 339
Lines 56814 56850 +36
==========================================
+ Hits 31634 31661 +27
- Misses 22535 22544 +9
Partials 2645 2645 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support K8S 1.32
Checklist: