fix: nil pointer on logging #4127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
|
Published E2E Test Results 4 files 4 suites 3h 14m 6s ⏱️ For more details on these failures, see this check. Results for commit 9597437. |
Published Unit Test Results2 295 tests 2 295 ✅ 2m 59s ⏱️ Results for commit 9597437. |
agaudreault
approved these changes
Feb 12, 2025
zachaller
added a commit
that referenced
this pull request
Feb 12, 2025
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
zachaller
added
the
cherry-pick-completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we err rs can be nil, so lets not use it in the logging.