fix: deduplicate the outputs YAML to JSON conversion error #14051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakio
suggested changes
Jan 5, 2025
pkg/apiclient/apiclient.go
Outdated
Comment on lines
67
to
69
| if opts.Offline { | ||
| return newOfflineClient(opts.OfflineFiles) | ||
| } |
There was a problem hiding this comment.
I don't think can just ignore --offline option, it will fail back to newArgoKubeClient and won't work without configuring the kubernetes.
Here's the error I've got running the command with your change, without any k8s/k8s-alternative configured.
$ ./dist/argo lint ./examples/*.yaml --offline
Error: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variabl
chansuke
force-pushed
the
fix/duplicated-outputs
branch
2 times, most recently
from
40a46be to
6317b5e
Compare
|
any updates |
|
@shuangkun |
…ne mode Signed-off-by: chansuke <moonset20@gmail.com>
chansuke
force-pushed
the
fix/duplicated-outputs
branch
from
6317b5e to
31a6815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14050
Motivation
Deduplicate the output of YAML to JSON conversion error.
Modifications
Verification
Checked the output with:
And also with unit test.