test: fix the 1px diff issue while testing in playwright

arianrhodsandlot · Jan 23, 2025 · f287b0c · f287b0c
1 parent e8d7ae0
commit f287b0c
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 4 deletions.
diff --git a/playground/activate.ts b/playground/activate.ts
@@ -102,7 +102,12 @@ const handlers = {
     })
     document.body.append(image)
   },
+
+  exit() {
+    nostalgist.exit()
+  },
 }
+
 export function activate(mod: typeof Nostalgist_) {
   const nostalgistConfig = {
     style: {

diff --git a/playground/index.html b/playground/index.html
@@ -9,12 +9,28 @@
     <style>
       body {
         text-align: center;
+        line-height: normal;
       }
+
       h1 {
         display: flex;
         justify-content: center;
         align-items: center;
         gap: 10px;
+        margin: 32px auto 0 auto;
+      }
+
+      h3 {
+        margin: 10px auto;
+      }
+
+      button {
+        line-height: normal;
+        cursor: pointer;
+      }
+
+      button:disabled {
+        cursor: wait;
       }
     </style>
   </head>
@@ -47,6 +63,7 @@ <h3>Instance Methods</h3>
       <button type="button">pressA</button>
       <button type="button">pressStart</button>
       <button type="button">screenshot</button>
+      <button type="button">exit</button>
     </div>
 
     <script type="module">

diff --git a/src/classes/emulator.ts b/src/classes/emulator.ts
@@ -78,13 +78,13 @@ export class Emulator {
   }
 
   exit(statusCode = 0) {
-    const { emscripten } = this
-    if (emscripten) {
+    try {
       const { exit, JSEvents } = this.getEmscripten()
       exit(statusCode)
-      this.fs.dispose()
       JSEvents.removeAllEventListeners()
-    }
+    } catch {}
+
+    this.fs.dispose()
   }
 
   getEmscripten() {