Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindgen C2A RESULT type #344

Merged
merged 1 commit into from
May 17, 2024
Merged

bindgen C2A RESULT type #344

merged 1 commit into from
May 17, 2024

Conversation

sksat
Copy link
Member

@sksat sksat commented May 16, 2024

概要

SSIA

詳細

  • library/result.h を bindgen して c2a_core::library::RESULT として Rust 側に公開する
  • Rust 側でC言語側から呼び出すコードを実装することが多く、その際のエラー返却を容易にするため

影響範囲

c2a-core crate

@sksat sksat added the enhancement New feature or request label May 16, 2024
@sksat sksat added this to the v4.5.0 milestone May 16, 2024
@sksat sksat requested a review from KOBA789 May 16, 2024 07:52
@sksat sksat self-assigned this May 16, 2024
KOBA789
KOBA789 approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@KOBA789 KOBA789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嬉しい

@sksat
Copy link
Member Author

sksat commented May 17, 2024

なぜか CI で cargo build コケてるな

@sksat
Copy link
Member Author

sksat commented May 17, 2024

キャッシュかな

@sksat
Copy link
Member Author

sksat commented May 17, 2024

普通に commit 忘れだった

@sksat sksat force-pushed the feature/bindgen-c2a-result branch from 81f10c5 to 09d1659 Compare May 17, 2024 05:05
@sksat sksat merged commit 15a7264 into main May 17, 2024
37 checks passed
@sksat sksat deleted the feature/bindgen-c2a-result branch May 17, 2024 05:17
@sksat sksat mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KOBA789 KOBA789 KOBA789 approved these changes

Assignees

@sksat sksat

Labels
enhancement New feature or request
Projects
C2A public
Status: Done
Milestone
v4.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sksat @KOBA789