Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NodeJS package manager to pnpm #353

Merged
merged 8 commits into from
Jul 22, 2024
Merged

Move NodeJS package manager to pnpm #353

merged 8 commits into from
Jul 22, 2024

Conversation

sksat
Copy link
Member

@sksat sksat commented May 17, 2024

概要

SSIA

Issue

詳細

検証結果

pytest CI が通ればよし

影響範囲

C2A Boom

@sksat sksat added priority::high priorityg high tools labels May 17, 2024
@sksat sksat added this to the v4.5.0 milestone May 17, 2024
@sksat sksat requested a review from KOBA789 May 17, 2024 07:12
@sksat sksat self-assigned this May 17, 2024
@sksat sksat force-pushed the feature/move-to-pnpm branch from b9765ce to 83836cf Compare May 17, 2024 07:22
@sksat
Copy link
Member Author

sksat commented Jul 4, 2024

rebase

@sksat sksat force-pushed the feature/move-to-pnpm branch 4 times, most recently from bf67b10 to 23126ce Compare July 4, 2024 08:13
@KOBA789
Copy link
Member

KOBA789 commented Jul 8, 2024

! Corepack is about to download https://registry.npmjs.org/pnpm/-/pnpm-9.4.0.tgz
 ERR_PNPM_NO_GLOBAL_BIN_DIR  Unable to find the global bin directory

Run "pnpm setup" to create it automatically, or set the global-bin-dir setting, or the PNPM_HOME env variable. The global bin directory should be in the PATH.

とのことですけども……(初めて見るエラーだ)

@KOBA789
Copy link
Member

KOBA789 commented Jul 8, 2024

あーこれ既に actions/setup-node が pnpm 入れてるから pnpm のインストールが衝突してるのか?

@sksat
Copy link
Member Author

sksat commented Jul 16, 2024

rebase

@sksat sksat force-pushed the feature/move-to-pnpm branch from 23126ce to 08c2224 Compare July 16, 2024 16:08
@sksat
Copy link
Member Author

sksat commented Jul 16, 2024

いや、actions/setup-node なくても出るな

@sksat sksat force-pushed the feature/move-to-pnpm branch from 8a63434 to 9702b4f Compare July 16, 2024 16:33
@sksat
Copy link
Member Author

sksat commented Jul 22, 2024

やや不本意だが pnpm/action-setup 使うか

@sksat sksat force-pushed the feature/move-to-pnpm branch from 5b06a9f to 0b70701 Compare July 22, 2024 19:15
@sksat sksat force-pushed the feature/move-to-pnpm branch from 0b70701 to c92a8b5 Compare July 22, 2024 19:18
@sksat sksat requested a review from KOBA789 July 22, 2024 19:30
Copy link
Member

@KOBA789 KOBA789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そういえば、pnpm が打ちづらいのは公式も認識しているようで、インストール手順の最後にエイリアスを貼る方法が紹介されているほどです。
もしかしたら C2A のドキュメントでもそれを案内してもいい、かもしれない(要らんことは案内しないほうがいいという説もかなりあるけど)
https://pnpm.io/installation#using-a-shorter-alias

@sksat
Copy link
Member Author

sksat commented Jul 22, 2024

要らんことは案内しない方がいい(分かっている人は調べりゃ勝手にやるし、分かってない人が alias をゴチャッとやると悲惨だしデバッグが困難になる)

@sksat
Copy link
Member Author

sksat commented Jul 22, 2024

そもそも打つ頻度がそんなにだし

@sksat sksat merged commit 6512540 into main Jul 22, 2024
39 checks passed
@sksat sksat deleted the feature/move-to-pnpm branch July 22, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants