Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure c2a-core crate MSRV & set to 1.78 #425

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Conversation

sksat
Copy link
Member

@sksat sksat commented Mar 12, 2025

  • Update Rust to 1.78.0 #424 でこのリポジトリの rustup の設定で Rust のバージョンを 1.78.0 に上げた
  • これは lockfile v4 に伴う(Rust 側の)breaking change によるもの
    • 正確には後方互換性はあるのだが、デフォルトで出力される lockfile が v4 になった(かつ、Renovate がそれに伴って v4 にしてくるようになった)ことによって、事実上の breaking change となっている
  • しかし一方で、これはこのリポジトリ内の設定でしかなく、C2A user には波及しない設定となっている
  • そして、今回 Rust version を 1.78.0 にしたのは、全社的な MSRV を 1.78.0 とするため
  • これを実際の(C2A user 含めた)ビルドにも波及させるため、明示的に MSRV を設定し、このバージョンも 1.78.0 とする

@sksat sksat requested review from ymgyt and Copilot March 12, 2025 02:41
@sksat sksat self-assigned this Mar 12, 2025
@sksat sksat added tools priority::high priorityg high labels Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MSRV configuration for the c2a-core crate to align with the company-wide standard.

  • Updates the rust-version in Cargo.toml to require Rust 1.78.
  • Ensures that the crate’s configuration supports the lockfile v4 standard for compatibility.
Comments suppressed due to low confidence (1)

Cargo.toml:35

  • The updated MSRV is set to '1.78' but the title and description indicate '1.78.0'. For clarity and consistency, consider using the full version string '1.78.0'.
rust-version = "1.78"
@sksat
Copy link
Member Author

sksat commented Mar 12, 2025

これって patch version まで指定すべきか?ややすべきか

@sksat sksat force-pushed the feature/configure-msrv branch from 6bf91bd to d0bb540 Compare March 12, 2025 02:43
@sksat
Copy link
Member Author

sksat commented Mar 12, 2025

なおした

@sksat sksat requested a review from Copilot March 12, 2025 02:43
Copy link
Member

@ymgyt ymgyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます、LGTMです

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the minimum supported Rust version (MSRV) for the c2a-core crate to 1.78.0 to align with the company-wide Rust version standard and address changes in the lockfile version.

  • Update Cargo.toml by adding rust-version = "1.78.0"
  • Ensure compatibility with lockfile v4 and the overall MSRV requirement
@sksat sksat merged commit 555b44a into main Mar 12, 2025
37 checks passed
@sksat sksat deleted the feature/configure-msrv branch March 12, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants