Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1086] remove probe use of hardcoded name to reflect cr name #1092

Merged
merged 1 commit into from
Feb 11, 2025
Merged

[#1086] remove probe use of hardcoded name to reflect cr name #1092

merged 1 commit into from
Feb 11, 2025

Conversation

gtully
Copy link
Contributor

@gtully gtully commented Feb 11, 2025

No description provided.

@gtully gtully requested a review from brusdev February 11, 2025 11:15
brusdev
brusdev approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@brusdev brusdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giod catch! Is there a simple way to test the liveness probe?

@gtully
Copy link
Contributor Author

gtully commented Feb 11, 2025

I would have to make the test wait for a probe to expire and verify the restart count. At the moment the test is too fast to notice. I think I will end up doing that in the context of respecting the configuration of the name attribute of a broker. If anything other than the the cr name is applied, the the default probe will fail

@gtully gtully merged commit fd7bcf7 into arkmq-org:main Feb 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brusdev brusdev brusdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtully @brusdev