-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#885] Add ready printer column to ActiveMQArtemis CRD #886
Conversation
I'm wondering it would be good to have the same status than the one in the OpenShift plugin? Over there it says |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, it is great to expose our Ready status.
it begs the question, when false, what is the next command to run, to see the false conditions. |
I think we short cut in the status generation on the first false. We would need to improve on that to have an X ok/N detail |
I see your point but I also like the current status that only shows the first fatal error because in some way drives the users to resolve all error in an ordered sequence: validation, deployment, running |
Sorry I missed your suggestion, it LGTM but that requires a new field in the status. Can you create a new enhancement issue? |
The kubectl tool relies on server-side output formatting. Your cluster's API server decides which columns are shown by the kubectl get command. You can customize these columns for a CustomResourceDefinition, see https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#additional-printer-columns