Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#885] Add ready printer column to ActiveMQArtemis CRD #886

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

brusdev
Copy link
Contributor

@brusdev brusdev commented Apr 22, 2024

The kubectl tool relies on server-side output formatting. Your cluster's API server decides which columns are shown by the kubectl get command. You can customize these columns for a CustomResourceDefinition, see https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#additional-printer-columns

$ kubectl apply -f examples/artemis/artemis_single.yaml 
activemqartemis.broker.amq.io/artemis-broker created
$ kubectl get aa --watch
NAME             READY   AGE
artemis-broker   False   3s
artemis-broker   True    11s

@brusdev brusdev requested a review from gtully April 22, 2024 08:15
@lavocatt
Copy link
Contributor

I'm wondering it would be good to have the same status than the one in the OpenShift plugin? Over there it says 5 ok / 5 when all the conditions are met. Wdyt?

Copy link
Contributor

@gtully gtully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, it is great to expose our Ready status.

@gtully
Copy link
Contributor

gtully commented Apr 22, 2024

it begs the question, when false, what is the next command to run, to see the false conditions.
afaik, currently we don't populate or evaluate all the conditions once there is a false so we don't have the x/N information of ok statuses.

@gtully
Copy link
Contributor

gtully commented Apr 22, 2024

I'm wondering it would be good to have the same status than the one in the OpenShift plugin? Over there it says 5 ok / 5 when all the conditions are met. Wdyt?

I think we short cut in the status generation on the first false. We would need to improve on that to have an X ok/N detail

@brusdev brusdev merged commit 426af6b into arkmq-org:main Apr 22, 2024
4 checks passed
@brusdev
Copy link
Contributor Author

brusdev commented Apr 22, 2024

I'm wondering it would be good to have the same status than the one in the OpenShift plugin? Over there it says 5 ok / 5 when all the conditions are met. Wdyt?

I think we short cut in the status generation on the first false. We would need to improve on that to have an X ok/N detail

I see your point but I also like the current status that only shows the first fatal error because in some way drives the users to resolve all error in an ordered sequence: validation, deployment, running

@brusdev
Copy link
Contributor Author

brusdev commented Apr 25, 2024

I'm wondering it would be good to have the same status than the one in the OpenShift plugin? Over there it says 5 ok / 5 when all the conditions are met. Wdyt?

Sorry I missed your suggestion, it LGTM but that requires a new field in the status. Can you create a new enhancement issue?

@lavocatt
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants