Create and configure custom web status checker [API-417] #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nikhiltri
requested changes
Feb 13, 2025
|
|
||
| $this->info('Starting monitoring of domains: ' . implode(', ', $domains)); | ||
|
|
||
| while (true) { |
There was a problem hiding this comment.
So we expect this command always to be running? while (true) worries me. I wonder if, instead, we can think of this command as:
- Check all the domains in the list once, and log the status somewhere
- Go through the domain statuses and decide if any action needs to be taken on any of them
Then we can think of the code in this script as a single iteration, and have the Kernel below set to run the command every minute.
Comment on lines
+60
to
+61
| $this->info("Error monitoring {$domain}: " . $e->getMessage()); | ||
| Log::error("Monitoring error for {$domain}: " . $e->getMessage()); |
There was a problem hiding this comment.
Could you just use $this->error() here?
| 'text' => $message | ||
| ]); | ||
| } catch (\Exception $e) { | ||
| Log::error('Failed to send Slack message: ' . $e->getMessage()); |
There was a problem hiding this comment.
Consider $this->error() for uniformity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.