fix(my collection): re-enable artwork editing regardless of submissio…

…n status (#15213)

* fix(my collection): re-enable artwork editing regardless of submission status

* fix: don't overfetch data

src/Apps/MyCollection/Routes/MyCollectionArtwork/Components/MyCollectionArtworkHeader.tsx

@@ -17,28 +17,24 @@ export const MyCollectionArtworkHeader: React.FC<
     useMyCollectionTracking()
 
   const artwork = useFragment(FRAGMENT, props.artwork)
-  const showEditCTA = !artwork.consignmentSubmission?.internalID
 
   return (
     <Flex pt={2} justifyContent="space-between" alignItems="center">
       <MyCollectionArtworkBackButton />
-
-      {showEditCTA && (
-        <Button
-          // @ts-ignore
-          as={RouterLink}
-          variant="secondaryNeutral"
-          size="small"
-          to={`/collector-profile/my-collection/artworks/${artwork.internalID}/edit`}
-          onClick={() =>
-            trackEditCollectedArtwork(artwork.internalID, artwork.slug)
-          }
-          alignSelf="flex-end"
-        >
-          <Media greaterThanOrEqual="sm">Edit Artwork Details</Media>
-          <Media lessThan="sm">Edit</Media>
-        </Button>
-      )}
+      <Button
+        // @ts-ignore
+        as={RouterLink}
+        variant="secondaryNeutral"
+        size="small"
+        to={`/collector-profile/my-collection/artworks/${artwork.internalID}/edit`}
+        onClick={() =>
+          trackEditCollectedArtwork(artwork.internalID, artwork.slug)
+        }
+        alignSelf="flex-end"
+      >
+        <Media greaterThanOrEqual="sm">Edit Artwork Details</Media>
+        <Media lessThan="sm">Edit</Media>
+      </Button>
     </Flex>
   )
 }
@@ -47,8 +43,5 @@ const FRAGMENT = graphql`
   fragment MyCollectionArtworkHeader_artwork on Artwork {
     internalID
     slug
-    consignmentSubmission {
-      internalID
-    }
   }
 `

src/Apps/MyCollection/Routes/MyCollectionArtwork/Components/__tests__/MyCollectionArtworkHeader.jest.tsx

@@ -40,10 +40,10 @@ describe("MyCollectionArtworkHeader", () => {
     )
   })
 
-  it("does not display Edit Artwork Details CTA", () => {
+  it("displays Edit Artwork Details CTA even for submitted works", () => {
     renderWithRelay({ Artwork: () => mockResolversWithSubmission })
 
-    expect(screen.queryByText("Edit Artwork Details")).not.toBeInTheDocument()
+    expect(screen.queryByText("Edit Artwork Details")).toBeInTheDocument()
   })
 })