improvement: add igniter installer #113
Conversation
This work depends on composing the oban installer, and so can't be merged until this PR is merged: oban-bg/oban#1230
| adds_deps: [], | ||
| # dependencies to add and call their associated installers, if they exist | ||
| installs: [ | ||
| {:oban, "~> 2.0"} |
There was a problem hiding this comment.
This version of Oban was released in July 2020. It's far older than we'd recommend anybody use, and not fully compatible with newer dependencies. The ash_oban package itself is only a couple of years old. Perhaps specify a more recent minimum version, maybe ~> 2.17?
Of course, the only minor release that has an ash installer is v2.19, so perhaps it doesn't matter?
There was a problem hiding this comment.
It shouldn't really matter, but the real reason I did that is because mix igniter.install pins to the major version only, and if I put a higher version here the user will be prompted to change it to that higher version, even they they are certainly on a compatible version.
When oban task itself was updating the version, if ash_oban had a different dep string, then lyou could be asked to confirm the version 3 times consecutively 😂. Once for oban install, once for oban setting it, once for ash_oban setting it to the higher value.
But it's an interesting point that theoretically this would allow older versions. It could only happen if a dep was pinning oban to something older though, which seems unlikely.
This work depends on composing the oban installer, and so can't be merged until this PR is merged:
oban-bg/oban#1230
Contributor checklist