fix: remove release attestations #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/astral-sh/python-build-standalone/actions/runs/13165689836/job/36745165697 Remove release attestations until problem is resolved
zanieb
approved these changes
Feb 5, 2025
zanieb
pushed a commit
that referenced
this pull request
Feb 11, 2025
## Summary Reverts #514 This adds back support for release attestations after asset uploads. Turns out extended glob is not supported via subject-path given how the action searches the directories and applies the glob, so instead we declare multiple simple globs since subject-path supports that too. ## Test Plan A full release was tested with about 155 artifacts (had to limit release triplets since free runners have limited resources) which resulted in 76 subjects created due to filtering. See release here: https://github.com/samypr100/python-build-standalone/releases/tag/20250205 See run here: https://github.com/samypr100/python-build-standalone/actions/runs/13220724442/job/36905418053 See attestations here: https://github.com/samypr100/python-build-standalone/attestations/4870998
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/astral-sh/python-build-standalone/actions/runs/13165689836/job/36745165697
This remove release attestations for now until problem with glob resulting in no matches is identified