Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support requirements.txt for version-file #68

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

daveisfera
Copy link

No description provided.

@daveisfera daveisfera requested a review from eifinger as a code owner February 1, 2025 05:03
Copy link
Collaborator

@eifinger eifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

A few changes and we are good to go.

Don't forget to run npm run all so it creates the distribution.

README.md Outdated Show resolved Hide resolved
__tests__/fixtures/requirements/requirements.txt Outdated Show resolved Hide resolved
src/utils/pyproject.ts Outdated Show resolved Hide resolved
@daveisfera daveisfera force-pushed the version-file_requirements branch from b15526a to bb5308c Compare February 1, 2025 16:56
@daveisfera
Copy link
Author

I addressed all of the feedback and it should be ready to go

@daveisfera
Copy link
Author

Don't forget to run npm run all so it creates the distribution.

I have no experience packaging actions, so just out of curiosity, is the bundling of dist/index.js necessary? It feels like that should be a build/deploy step and not something that's checked into the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants