Add --exit-non-zero-on-format #16009
Conversation
|
| #[arg(long, help_heading = "Miscellaneous")] | ||
| pub exit_non_zero_on_format: bool, |
There was a problem hiding this comment.
Do you find ruff format --exit-non-zero-on-format awkward? Should it be ruff format --exit-non-zero-on-change or --exit-non-zero-on-write? It might be nice to switch to an agnostic name.
Should we retain the on_fix language we use for ruff check? I see the motivation for not, but at the very least we probably want an alias for parity with ruff check?
There was a problem hiding this comment.
The current name was meant to "reflect" "exit non zero on (action)", to mirror "on fix".
As for the ergonomics? I really don't have an opinion. I can't imagine anyone using this flag outside of some kind of config file or script file of some sort. In which case the name is really only as important as "can be discovered" and "name reflects what happens". So I think the bike shed on the name (past probably "exit non zero on ...") doesn't bother me. I'm happy to use whatever yall like most!
|
(On second thought, I do want to talk briefly about the name before merging) |
Summary
Fixes #8191 by introducing
--exit-non-zero-on-formattoruff formatwhich pretty much does what it says on the tin.Test Plan
Added a new test!