Skip to content

Commit

Permalink
fix(conductor): enable tls for grpc connections (#925)
Browse files Browse the repository at this point in the history
## Summary
Added a couple of tonic features to conductor so it can use tls and
http2 correctly.

## Background
When connecting over an https http2 (h2) connection conductor would get
errors stating `http2 error: connection error detected: frame with
invalid size, connection error detected: frame with invalid size`. Tonic
wasn't using tls because it wasn't turned on. Adding these two features
allows "native" certs for client to be used by default and uses tls and
http2 correctly when making client requests.

## Changes
- enabled `tls` and `tls-roots` features on tonic in conductor 

## Testing
Ran conductor locally against dusk-4 network. Additionally ran local
smoke test using the newly built image which confirmed still works over
non https urls.
  • Loading branch information
joroshiba authored Apr 5, 2024
1 parent 48391cd commit 99e53a6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/astria-conductor/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ sha2 = { workspace = true }
thiserror = { workspace = true }
tokio = { workspace = true, features = ["macros", "rt-multi-thread", "signal"] }
tokio-util = { workspace = true, features = ["rt"] }
tonic = { workspace = true }
tonic = { workspace = true, features = ["tls", "tls-roots"] }
tracing = { workspace = true, features = ["valuable"] }
tryhard = { workspace = true }

Expand Down

0 comments on commit 99e53a6

Please sign in to comment.