feat(charts): flame chart #1943
Conversation
charts/sequencer/values.yaml
Outdated
| @@ -131,7 +131,7 @@ sequencer: | |||
| otlpHeaders: | |||
| traceHeaders: | |||
| optimisticBlockApis: | |||
| enabled: false | |||
| enabled: true | |||
There was a problem hiding this comment.
do not enable it to true by default.
There was a problem hiding this comment.
Note that the user will have to manually change this as well to enable auctioneer. I have added it to the default value file as well for visibility.
| @@ -64,7 +64,6 @@ data: | |||
| ASTRIA_SEQUENCER_METRICS_HTTP_LISTENER_ADDR: "0.0.0.0:{{ .Values.ports.sequencerMetrics }}" | |||
| ASTRIA_SEQUENCER_FORCE_STDOUT: "{{ .Values.global.useTTY }}" | |||
| ASTRIA_SEQUENCER_PRETTY_PRINT: "{{ .Values.global.useTTY }}" | |||
| ASTRIA_NO_OPTIMISTIC_BLOCKS: "{{ not .Values.sequencer.optimisticBlockApis.enabled }}" | |||
There was a problem hiding this comment.
this shouldn't be removed?
There was a problem hiding this comment.
It is configured twice.
| sequencerChainId: "" | ||
| # The expected fastest block time possible from sequencer, determines polling | ||
| # rate. | ||
| sequencerBlockTimeMs: 2000 |
There was a problem hiding this comment.
lets just default this to 100 for flame rollups. Otherwise, we can potentially miss this while deploying since this is a critical parameter to have especially for the auctioneer flame node.
There was a problem hiding this comment.
we need the sequencerBlockTimeMs to be as less as possible in order to not have any race conditions between execute block and execute optimistic block when running the flame node as auctioneer node.
There was a problem hiding this comment.
Understood, but this is not ideal for deployment which does not use the auctioneer, in my opinion should stay as part of the deployment configuration.
There was a problem hiding this comment.
sure, but we need to ensure that we note that this value is set to 100ms specifically for the auctioneer flame node.
There was a problem hiding this comment.
I'll add a note and make sure this value is visible in the default value file.
| @@ -7,11 +7,11 @@ global: | |||
|
|
|||
| images: | |||
| auctioneer: | |||
| repo: ghcr.io/astriaorg/astria-auctioneer | |||
| repo: ghcr.io/astriaorg/auctioneer | |||
There was a problem hiding this comment.
Note, also bump up auctioneer's cpu usage.
There was a problem hiding this comment.
increase the auctioneer cpu limits to 2 and cpu requests to 1.
There was a problem hiding this comment.
for local deployments? I think it should stay at 1.
There was a problem hiding this comment.
discussed offline and the outcome is that we want values in charts to be valid for local deployment only.
Summary
Implements a new chart dedicated for the flame package and also integrates the new chart with the astria stack. The
evm-stacknow support runningastria-gethor the flame fork with an auctioneer out of the box.Background
To support auctioneer deployment we need to run geth flame fork, which implements the necessary changes in pr-30.
Changes
evm-stackreplace
just deploy-dev-rollupwithjust deploy-flame-dev-rollupin the deployment process to runflameinstead ofastria-geth.Notes:
Testing
running a local cluster and monitoring geth logs.
│ INFO [02-04|11:25:13.608] ExecuteOptimisticBlock completed block_num=52 timestamp=seconds:1738668312Changelogs
No updates required.