fix(charts): geth flags #1957
Merged
fix(charts): geth flags #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroshiba
reviewed
Feb 10, 2025
charts/evm-rollup/values.yaml
Outdated
| @@ -174,13 +174,13 @@ config: | |||
| - name: history.state | |||
| value: "{{- if .Values.config.geth.archiveNode -}} 0 {{- else -}} 540000 {{- end }}" | |||
| - name: metrics | |||
| condition: .Values.metrics.enabled | |||
| condition: "{{- if .Values.metrics.enabled -}} true {{- else -}} false {{- end }}" | |||
There was a problem hiding this comment.
Based on testing I believe this works fine
condition : "{{ .Values.metrics.enabled }}"
Comment on lines
70
to
74
| {{- if hasKey $arg "condition" }} | ||
| {{- if eq (tpl $arg.condition $) "true" }} | ||
| - --{{ $arg.name }}{{ if $arg.value }}={{ tpl $arg.value $ }}{{ end }} | ||
| {{- end }} | ||
| {{- else }} |
There was a problem hiding this comment.
We can probably keep this duplication to a minimum, can do same in the exec script?
If there is no condition set or the condition evaluates to true
Suggested change
| {{- if hasKey $arg "condition" }} | |
| {{- if eq (tpl $arg.condition $) "true" }} | |
| - --{{ $arg.name }}{{ if $arg.value }}={{ tpl $arg.value $ }}{{ end }} | |
| {{- end }} | |
| {{- else }} | |
| {{- $noCondition := not (hasKey $arg "condition") }} | |
| {{- if or ($noCondition) (eq (tpl $arg.condition $) "true") }} |
There was a problem hiding this comment.
Updated both statefulset and exec script with the new format, tested with and without metrics enabled using:
helm template my-chart ./charts/evm-stack -f ./dev/values/rollup/dev.yaml
quasystaty1
force-pushed
the
quasystaty1/charts/geth-flags
branch
from
a2f0cc9 to
c24fcde
Compare
joroshiba
approved these changes
Feb 12, 2025
quasystaty1
force-pushed
the
quasystaty1/charts/geth-flags
branch
from
14b8aa8 to
81c3147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
changes to how flags condition is evaluated and used.
Background
Our current evm-rollup charts has a bug, the condition which helps configuring geth flags is not being evaluated and always acts as
true. This PR changes the condition templating.Changes
trueif the condition exists.Testing
helm template my-chart ./charts/evm-stack -f ./dev/values/rollup/dev.yamlChangelogs
No updates required.