Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bridge-signer): implement FROST threshold signer node #1960

Open
wants to merge 14 commits into
base: noot/bridge-withdrawer
Choose a base branch
from

Conversation

noot
Copy link
Collaborator

@noot noot commented Feb 10, 2025

Summary

implement FROST threshold signer node which implements the FrostParticipantService gRPC service defined in #1948. the bridge withdrawer can then collect signature partials from various threshold signer nodes to sign a withdrawal transaction in a more distributed manner.

Background

improves security of the withdrawer over having one private key used; instead, we can employ an m-of-n threshold signature scheme to sign withdrawals.

Changes

  • implement FROST threshold signer node which implements the FrostParticipantService gRPC service
  • currently, the signer is evm-rollup specific; when it receives a sequencer withdrawal tx to sign, it verifies that the withdrawals are valid using an evm rollup node. specifically, it performs the same logic that the withdrawer uses to create the withdrawal tx in the first place (one tx = every withdrawal in an evm block converted to an action) to verify.

Testing

tested with the withdrawer in #1948; see https://www.notion.so/astria-org/bridge-threshold-withdrawer-testing-1936bd31a90c803ab33ccc1221f545a1?pvs=4

Changelogs

Ensure all relevant changelog files are updated as necessary. See
keepachangelog for change
categories. Replace this text with e.g. "Changelogs updated." or "No updates
required." to acknowledge changelogs have been considered.

Related Issues

closes #1937

@github-actions github-actions bot added the sequencer pertaining to the astria-sequencer crate label Feb 10, 2025
@noot noot marked this pull request as ready for review February 11, 2025 16:35
@noot noot requested review from SuperFluffy, Fraser999, a team and joroshiba as code owners February 11, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sequencer pertaining to the astria-sequencer crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant