Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(proto): adhere to 1-1-1 #1964

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore(proto): adhere to 1-1-1 #1964

wants to merge 6 commits into from

Conversation

joroshiba
Copy link
Member

@joroshiba joroshiba commented Feb 12, 2025

Summary

Updates all core protobuf types to follow 1-1-1 best practice.

Background

We have some large (potentially oversized) protobuf defintions which make it such that imports where importing more than necessary. Migrating to a 1-1-1 practice as documented as best practice, ensures that imports into required modules have the minimum set needed.

Changes

  • Updates all protobufs to follow 1-1-1 best practice

Testing

CI/CD tests

Metrics

  • List out metrics added by PR, delete section if none.

Breaking Changelist

  • This PR will change some of the exported buf packages in a breaking manner, as there are some types no longer in their export. These types are considered bloat which were unintentionally included previously.

@github-actions github-actions bot added the proto pertaining to the Astria Protobuf spec label Feb 12, 2025
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I did not fully break up the fee_components as these are purposefully identical right now and it seemed overkill.

@joroshiba joroshiba marked this pull request as ready for review February 17, 2025 21:24
@joroshiba joroshiba requested review from a team, SuperFluffy and Fraser999 as code owners February 17, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-breaking-proto proto pertaining to the Astria Protobuf spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants