refactor(conductor)!: use HTTP to periodically poll Celestia heights #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperFluffy
force-pushed
the
superfluffy/purge-websockets
branch
from
919630f to
fb789c4
Compare
SuperFluffy
changed the title
SuperFluffy
force-pushed
the
superfluffy/purge-websockets
branch
from
fb789c4 to
23e1499
Compare
SuperFluffy
force-pushed
the
superfluffy/purge-websockets
branch
4 times, most recently
from
9ca74ae to
e1c08f6
Compare
aajimal
approved these changes
Apr 5, 2024
noot
reviewed
Apr 5, 2024
| let mut interval = tokio::time::interval(poll_period); | ||
| interval.set_missed_tick_behavior(tokio::time::MissedTickBehavior::Skip); | ||
| LatestHeightStream { | ||
| inner: IntervalStream::new(interval).then(f), |
There was a problem hiding this comment.
did not know about this, very cool
noot
reviewed
Apr 5, 2024
| .boxed() | ||
| }); | ||
| let mut interval = tokio::time::interval(poll_period); | ||
| interval.set_missed_tick_behavior(tokio::time::MissedTickBehavior::Skip); |
There was a problem hiding this comment.
skipping is ok b/c conductor will fetch all blocks if a few heights are missed in the stream right?
There was a problem hiding this comment.
Yeah, so say the last block fetched is 10 and the latest celestia height we observed is 10 - in this case no new blocks will be fetched.
If the stream fails for 9 consecutive heights but then 10th one succeeds, then the latest observed height jumps from 10 to 20. In that moment the stream schedules 11 to 20 one after the other.
…s in favor of periodic polling
SuperFluffy
force-pushed
the
superfluffy/purge-websockets
branch
from
e1c08f6 to
730e03a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the websocket subscription to get the latest Celestia heights by a HTTP fetch running periodically.
Background
Websocket adds complexity for questionable gain. Tests in particular are much more complex to set up, but also for normal operation disconnects and resubscriptions need to be handled explicitly because websocket does not have a reconnect mechanism.
This PR essentially comes full circle, removing every last trace of websocket again.
Changes
ASTRIA_CONDUCTOR_CELESTIA_NODE_WEBSOCKET_URLconfigASTRIA_CONDUCTOR_CELESTIA_BLOCK_TIME_MSconfig which takes an integer representing the duration in milliseconds between two successive Celestia block heights.Testing
Will be tested using blackbox tests and smoke tests (out of scope of this PR)
Breaking Changelist
ASTRIA_CONDUCTOR_CELESTIA_NODE_WEBSOCKET_URLASTRIA_CONDUCTOR_CELESTIA_BLOCK_TIME_MS