fix(docs): Fix doc for running a smoke test #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharath-123
requested review from
joroshiba,
noot and
SuperFluffy
as code owners
bharath-123
force-pushed
the
bharath/fix-smoke-test-docs
branch
from
5f9d0bb to
3b5d6bf
Compare
bharath-123
changed the title
noot
approved these changes
Mar 28, 2024
bharath-123
force-pushed
the
bharath/fix-smoke-test-docs
branch
from
3b5d6bf to
2ad74bf
Compare
joroshiba
approved these changes
Apr 1, 2024
bharath-123
force-pushed
the
bharath/fix-smoke-test-docs
branch
from
2ad74bf to
9ee7c6b
Compare
bharath-123
force-pushed
the
bharath/fix-smoke-test-docs
branch
from
9ee7c6b to
5e79cf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix doc for running a smoke-test in the
chartsdirectory.Background
The doc should be
just run-smoke-testinstead ofjust run smoke-testChanges
Testing
By running
just run-smoke-testand ensuring that it is successfully triggered.