test(sequencer): add unit tests for src/api_state_ext #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noot
reviewed
Apr 2, 2024
noot
reviewed
Apr 2, 2024
Comment on lines
+479
to
+443
| // create inner rollup id/tx data | ||
| let mut deposits = HashMap::new(); | ||
| for _ in 0..2 { |
There was a problem hiding this comment.
is this just adding 2 arbitrary deposit types?
There was a problem hiding this comment.
Yeah, I wanted to put rollup data in that could be read out. I can replace with normal non-deposit generated rollup transactions if you'd prefer.
noot
reviewed
Apr 2, 2024
noot
reviewed
Apr 2, 2024
noot
reviewed
Apr 5, 2024
| // create inner rollup id/tx data | ||
| let mut deposits = HashMap::new(); | ||
| for _ in 0..2 { | ||
| let rollup_id = RollupId::new([rng.gen(); 32]); |
There was a problem hiding this comment.
just curious, can you do:
Suggested change
| let rollup_id = RollupId::new([rng.gen(); 32]); | |
| let rollup_id = RollupId::new(rng.gen()); |
There was a problem hiding this comment.
yes you can! changed
Lilyjjo
force-pushed
the
lilyjjo/state-ext-unit-tests-7
branch
from
275eff3 to
77cc50b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Seventh set of state-ext unit tests. In total there are seven files which
need tests:
astria-sequencer/src/api_state_ext.rsastria-sequencer/src/state_ext.rsastria-sequencer/src/accounts/state_ext.rsastria-sequencer/src/asset/state_ext.rsastria-sequencer/src/authority/state_ext.rsastria-sequencer/src/bridge/state_ext.rsastria-sequencer/src/ibc/state_ext.rsThis PR just tests the
src/api_state_ext/state_ext.rsfile.Background
It is good to have unit tests to ensure that the database works as intended.
Changes
Unit tests for the functionality in the file
src/api_state_ext/state_ext.rswere added.Testing
:)