chore: patch from astria-geth migrated #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroshiba
requested review from
bharath-123
and removed request for
mycodecrafting and
noot
bharath-123
reviewed
Feb 20, 2025
Comment on lines
+303
to
+305
| // DepositTx can only be generated through execution pathway | ||
| if signedTx.Type() == types.BlobTxType || signedTx.Type() == types.DepositTxType { | ||
| return types.ErrTxTypeNotSupported |
There was a problem hiding this comment.
Nit: Would probably be nice to have more specific error messages.
|
have tested this locally with the auctioneer smoke-test and it seems to be working fine. |
bharath-123
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the patch from astria-geth: astriaorg/astria-geth#70 with modification for the
backend.gowhich is otherwise already modified in flame to be as close as possible.