Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quasystaty1/bump hermes 1.10.3 docker fix #22

Draft
wants to merge 4 commits into
base: noot/bump-hermes-1.10.3
Choose a base branch
from

use noot modified astria deps

ddce5a5
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Quasystaty1/bump hermes 1.10.3 docker fix #22

use noot modified astria deps
ddce5a5
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy-no-default-features failed Oct 20, 2024 in 0s

clippy-no-default-features

32 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 32
Warning 0
Note 0
Help 0

Versions

  • rustc 1.82.0 (f6e511eec 2024-10-15)
  • cargo 1.82.0 (8f40fc59f 2024-08-21)
  • clippy 0.1.82 (f6e511e 2024-10-15)

Annotations

Check failure on line 110 in crates/relayer/src/config.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

this manual char comparison can be written more succinctly

error: this manual char comparison can be written more succinctly
   --> crates/relayer/src/config.rs:110:16
    |
110 |         .split(|c| c == ',' || c == ';')
    |                ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `[',', ';']`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
    = note: `-D clippy::manual-pattern-char-comparison` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::manual_pattern_char_comparison)]`

Check failure on line 37 in crates/relayer/src/config/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

mutable key type

error: mutable key type
  --> crates/relayer/src/config/filter.rs:37:19
   |
37 |         min_fees: HashMap<ChannelFilterMatch, FeePolicy>,
   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type

Check failure on line 16 in crates/relayer/src/config/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

mutable key type

error: mutable key type
  --> crates/relayer/src/config/filter.rs:16:50
   |
16 | #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
   |                                                  ^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type
   = note: `-D clippy::mutable-key-type` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::mutable_key_type)]`
   = note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 110 in crates/relayer/src/config.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

this manual char comparison can be written more succinctly

error: this manual char comparison can be written more succinctly
   --> crates/relayer/src/config.rs:110:16
    |
110 |         .split(|c| c == ',' || c == ';')
    |                ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `[',', ';']`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
    = note: `-D clippy::manual-pattern-char-comparison` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::manual_pattern_char_comparison)]`

Check failure on line 37 in crates/relayer/src/config/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

mutable key type

error: mutable key type
  --> crates/relayer/src/config/filter.rs:37:19
   |
37 |         min_fees: HashMap<ChannelFilterMatch, FeePolicy>,
   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type

Check failure on line 16 in crates/relayer/src/config/filter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

mutable key type

error: mutable key type
  --> crates/relayer/src/config/filter.rs:16:50
   |
16 | #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
   |                                                  ^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type
   = note: `-D clippy::mutable-key-type` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::mutable_key_type)]`
   = note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 21 in crates/relayer/src/chain/astria/utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

use of a fallible conversion when an infallible one could be used

error: use of a fallible conversion when an infallible one could be used
  --> crates/relayer/src/chain/astria/utils.rs:21:10
   |
21 |         .try_into()
   |          ^^^^^^^^ help: use: `into`
   |
   = note: converting `MerkleProof` to `MerkleProof` cannot fail
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
   = note: `-D clippy::unnecessary-fallible-conversions` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::unnecessary_fallible_conversions)]`

Check failure on line 21 in crates/relayer/src/chain/astria/utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

use of a fallible conversion when an infallible one could be used

error: use of a fallible conversion when an infallible one could be used
  --> crates/relayer/src/chain/astria/utils.rs:21:10
   |
21 |         .try_into()
   |          ^^^^^^^^ help: use: `into`
   |
   = note: converting `MerkleProof` to `MerkleProof` cannot fail
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
   = note: `-D clippy::unnecessary-fallible-conversions` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::unnecessary_fallible_conversions)]`

Check failure on line 1491 in crates/relayer/src/chain/astria/endpoint.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unused variable: `include_proof`

error: unused variable: `include_proof`
    --> crates/relayer/src/chain/astria/endpoint.rs:1491:9
     |
1491 |         include_proof: IncludeProof,
     |         ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_include_proof`

Check failure on line 1490 in crates/relayer/src/chain/astria/endpoint.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unused variable: `height`

error: unused variable: `height`
    --> crates/relayer/src/chain/astria/endpoint.rs:1490:9
     |
1490 |         height: Height,
     |         ^^^^^^ help: if this is intentional, prefix it with an underscore: `_height`

Check failure on line 1489 in crates/relayer/src/chain/astria/endpoint.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unused variable: `request`

error: unused variable: `request`
    --> crates/relayer/src/chain/astria/endpoint.rs:1489:9
     |
1489 |         request: QueryUpgradeErrorRequest,
     |         ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_request`

Check failure on line 1482 in crates/relayer/src/chain/astria/endpoint.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unused variable: `include_proof`

error: unused variable: `include_proof`
    --> crates/relayer/src/chain/astria/endpoint.rs:1482:9
     |
1482 |         include_proof: IncludeProof,
     |         ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_include_proof`

Check failure on line 1481 in crates/relayer/src/chain/astria/endpoint.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unused variable: `height`

error: unused variable: `height`
    --> crates/relayer/src/chain/astria/endpoint.rs:1481:9
     |
1481 |         height: Height,
     |         ^^^^^^ help: if this is intentional, prefix it with an underscore: `_height`

Check failure on line 1480 in crates/relayer/src/chain/astria/endpoint.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unused variable: `request`

error: unused variable: `request`
    --> crates/relayer/src/chain/astria/endpoint.rs:1480:9
     |
1480 |         request: QueryUpgradeRequest,
     |         ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_request`
     |
     = note: `-D unused-variables` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(unused_variables)]`

Check failure on line 21 in crates/relayer/src/transfer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unused import: `prost::Message`

error: unused import: `prost::Message`
  --> crates/relayer/src/transfer.rs:21:5
   |
21 | use prost::Message;
   |     ^^^^^^^^^^^^^^

Check failure on line 1491 in crates/relayer/src/chain/astria/endpoint.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unused variable: `include_proof`

error: unused variable: `include_proof`
    --> crates/relayer/src/chain/astria/endpoint.rs:1491:9
     |
1491 |         include_proof: IncludeProof,
     |         ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_include_proof`

Check failure on line 1490 in crates/relayer/src/chain/astria/endpoint.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unused variable: `height`

error: unused variable: `height`
    --> crates/relayer/src/chain/astria/endpoint.rs:1490:9
     |
1490 |         height: Height,
     |         ^^^^^^ help: if this is intentional, prefix it with an underscore: `_height`

Check failure on line 1489 in crates/relayer/src/chain/astria/endpoint.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unused variable: `request`

error: unused variable: `request`
    --> crates/relayer/src/chain/astria/endpoint.rs:1489:9
     |
1489 |         request: QueryUpgradeErrorRequest,
     |         ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_request`

Check failure on line 1482 in crates/relayer/src/chain/astria/endpoint.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unused variable: `include_proof`

error: unused variable: `include_proof`
    --> crates/relayer/src/chain/astria/endpoint.rs:1482:9
     |
1482 |         include_proof: IncludeProof,
     |         ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_include_proof`

Check failure on line 1481 in crates/relayer/src/chain/astria/endpoint.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unused variable: `height`

error: unused variable: `height`
    --> crates/relayer/src/chain/astria/endpoint.rs:1481:9
     |
1481 |         height: Height,
     |         ^^^^^^ help: if this is intentional, prefix it with an underscore: `_height`

Check failure on line 1480 in crates/relayer/src/chain/astria/endpoint.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unused variable: `request`

error: unused variable: `request`
    --> crates/relayer/src/chain/astria/endpoint.rs:1480:9
     |
1480 |         request: QueryUpgradeRequest,
     |         ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_request`
     |
     = note: `-D unused-variables` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(unused_variables)]`

Check failure on line 21 in crates/relayer/src/transfer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unused import: `prost::Message`

error: unused import: `prost::Message`
  --> crates/relayer/src/transfer.rs:21:5
   |
21 | use prost::Message;
   |     ^^^^^^^^^^^^^^

Check failure on line 198 in crates/relayer/src/transfer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

redundant field names in struct initialization

error: redundant field names in struct initialization
   --> crates/relayer/src/transfer.rs:198:9
    |
198 |         denom: denom,
    |         ^^^^^^^^^^^^ help: replace it with: `denom`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
    = note: `-D clippy::redundant-field-names` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::redundant_field_names)]`

Check failure on line 198 in crates/relayer/src/transfer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

redundant field names in struct initialization

error: redundant field names in struct initialization
   --> crates/relayer/src/transfer.rs:198:9
    |
198 |         denom: denom,
    |         ^^^^^^^^^^^^ help: replace it with: `denom`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
    = note: `-D clippy::redundant-field-names` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::redundant_field_names)]`

Check failure on line 59 in crates/relayer/src/connection.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unused import: `crate::util::retry::clamp_total`

error: unused import: `crate::util::retry::clamp_total`
  --> crates/relayer/src/connection.rs:59:9
   |
59 |     use crate::util::retry::clamp_total;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^