Add on_warning_callback to DbtSourceKubernetesOperator and refactor previous operators
#1501
+122
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
dosubot
bot
added
area:testing
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
tatiana
changed the title
on_warning_callback to DbtSourceKubernetesOperator and refactor previous operators
tatiana
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
This looks great, @LuigiCerone , thank you very much for raising the issue and the fix so promptly - the refactor looks great. I'm happy to merge this PR once the CI checks pass - and we'll release this as part of Cosmos 1.9.0.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1501 +/- ##
==========================================
+ Coverage 97.11% 97.13% +0.02%
==========================================
Files 77 77
Lines 4501 4505 +4
==========================================
+ Hits 4371 4376 +5
+ Misses 130 129 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems that
DbtSourceKubernetesOperatoris missing some logic for handling theon_warning_callback. This logic was added forDbtTestKubernetesOperatorin #673 , I tried to apply the same logic also for the source operator.Related Issue(s)
closes #1500 1500
Breaking Change?
AFAIK nope
Checklist