Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workload identity support #206

Merged
merged 19 commits into from
Feb 18, 2025
Merged

add workload identity support #206

merged 19 commits into from
Feb 18, 2025

Conversation

aliotta
Copy link
Contributor

@aliotta aliotta commented Feb 6, 2025

Description

Adds support for workload identity via a option desired workload identity param.

#23877

🎟 Issue(s)

🧪 Functional Testing

📸 Screenshots

On create no errors:
Screenshot 2025-02-06 at 9 48 58 AM
On update of a non-workload identity param no errors:
Screenshot 2025-02-06 at 9 49 03 AM
On update of a workload identity param no errors:
Screenshot 2025-02-06 at 9 49 03 AM
UI on create:
Screenshot 2025-02-06 at 9 49 31 AM
UI on update:
Screenshot 2025-02-06 at 9 52 24 AM
Generated .tf from import script:
Screenshot 2025-02-06 at 2 58 40 PM
Updating the workload identity:
Screenshot 2025-02-06 at 2 58 57 PM
Results of update in ui:
Screenshot 2025-02-06 at 2 59 16 PM

📋 Checklist

  • Added/updated applicable tests
  • Added/updated examples in the examples/ directory
  • Updated any related documentation

@aliotta aliotta requested review from vandyliu and a team as code owners February 6, 2025 14:50
Copy link
Collaborator

@ichung08 ichung08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks good overall, can you also test importing a deployment without workload identity and updating that?

@aliotta
Copy link
Contributor Author

aliotta commented Feb 6, 2025

change looks good overall, can you also test importing a deployment without workload identity and updating that?

good call I did need to make changes to the import script. One thing to note though is that deployments will always have a workload identity as if one is not sent the backend makes one for you.

@aliotta aliotta requested a review from vandyliu February 6, 2025 22:20
@yfried
Copy link

yfried commented Feb 13, 2025

thank you for this much needed feature.
Small question: why desired_workload_identity instead of simply workload_identity?

@aliotta
Copy link
Contributor Author

aliotta commented Feb 13, 2025

thank you for this much needed feature. Small question: why desired_workload_identity instead of simply workload_identity?

From the ticket I worked off of:

We need to support deployment workload identity in terraform however due to how we have workload identities in astro
terraform doesnt like the uncertain nature of the values
for eg. if we have workload_identity as optional and we set it as null, we create a deployment then the workload_identity is auto generated but in terraform we have it as null so terraform errors out

@aliotta aliotta merged commit f82f779 into main Feb 18, 2025
9 checks passed
@aliotta aliotta deleted the addWorkloadIdentSupport branch February 18, 2025 20:28
@chobberoni
Copy link
Collaborator

closes #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants