Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Doc and CI updates #251

Merged
merged 2 commits into from
Feb 21, 2025
Merged

MNT: Doc and CI updates #251

merged 2 commits into from
Feb 21, 2025

Conversation

pllim
Copy link
Member

@pllim pllim commented Feb 20, 2025

🐱

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credit goes to AA-Turner in astropy/astropy#17659

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.78%. Comparing base (5be52eb) to head (c2c04a2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   85.75%   85.78%   +0.03%     
==========================================
  Files          13       13              
  Lines        1151     1154       +3     
==========================================
+ Hits          987      990       +3     
  Misses        164      164              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim requested a review from hpparvi February 20, 2025 22:48
@pllim pllim added Build wheels Extra CI Run cron jobs on PR labels Feb 20, 2025
@pllim pllim marked this pull request as ready for review February 20, 2025 23:32
@pllim pllim requested review from kecnry and cshanahan1 February 20, 2025 23:33
* Enable building doc in Python 3.13, thus fixing linkcheck error.
* Add py313 to CI matrix.
* Get rid of doc build warnings, even if they do not fail build.
@pllim pllim force-pushed the doc-py313 branch 2 times, most recently from 5796d55 to bc4b429 Compare February 21, 2025 02:35
because no astropy test runner.
Handle upstream warning that appears because of this.
@hpparvi hpparvi merged commit 180c081 into astropy:main Feb 21, 2025
14 checks passed
@hpparvi
Copy link
Contributor

hpparvi commented Feb 21, 2025

Many thanks, @pllim!

@pllim pllim deleted the doc-py313 branch February 21, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build wheels Extra CI Run cron jobs on PR
Projects
None yet
2 participants