Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bkg_spectrum to take func instead of string #255

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pllim
Copy link
Member

@pllim pllim commented Feb 28, 2025

This is a direct follow-up of unreleased feature added in #253 so behavior change can be done without deprecation or change log.

I am just wondering what it would have looked like.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.84%. Comparing base (c31a9af) to head (4894825).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   85.93%   85.84%   -0.09%     
==========================================
  Files          13       13              
  Lines        1166     1159       -7     
==========================================
- Hits         1002      995       -7     
  Misses        164      164              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim marked this pull request as ready for review February 28, 2025 19:18
@kecnry
Copy link
Member

kecnry commented Feb 28, 2025

If we do this, I think we'd want to mirror that in the class-level statistic parameter, but that has additional logic and restriction to just median/average, which might be difficult to make fully general 🤷‍♂️

@pllim
Copy link
Member Author

pllim commented Feb 28, 2025

Where is the statistic? I was looking at Spectrum1D.collapse upstream which takes function.

@kecnry
Copy link
Member

kecnry commented Feb 28, 2025

@pllim
Copy link
Member Author

pllim commented Feb 28, 2025

Hmm... Should #253 have used this statistic instead of introducing a new keyword?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants