fix(lib.minimap): scroll by drag if scrollPastEnd #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@UziTech , Hi. I saw you previously merged some PRs to this repository. Thanks. |
aminya
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was problem if scroll past end enabled.
No scroll past end - all is well.
Enabled - there's some offset between mouse on screen on minimap and actual screen.
Screencast: https://youtu.be/zfAk14_9CEQ
This should fix it.
I checked by console.log when scrolling, mouse position was bigger when scrolling to bottom then height of minimap.
So it didn't account space added if scroll past end enabled.
"Minimap.getHeight" should return total height of minimap (is this true ?) (I read it in method description), so this PR also accounts space after last line added if scroll past end enabled.