Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add initial metrics for p2p comms #435

Merged
merged 9 commits into from
Feb 23, 2025

Conversation

maschad
Copy link
Member

@maschad maschad commented Feb 21, 2025

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.58824% with 201 lines in your changes missing coverage. Please review.

Project coverage is 67.06%. Comparing base (b7e8c14) to head (0000a5d).
Report is 63 commits behind head on main.

Files with missing lines Patch % Lines
atoma-p2p/src/metrics.rs 0.00% 152 Missing ⚠️
atoma-p2p/src/utils.rs 29.54% 31 Missing ⚠️
atoma-p2p/src/service.rs 0.00% 15 Missing ⚠️
atoma-p2p/src/tests.rs 98.99% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   66.63%   67.06%   +0.42%     
==========================================
  Files          43       49       +6     
  Lines        7646     9100    +1454     
==========================================
+ Hits         5095     6103    +1008     
- Misses       2551     2997     +446     
Files with missing lines Coverage Δ
atoma-p2p/src/timer.rs 0.00% <ø> (ø)
atoma-p2p/src/types.rs 95.89% <ø> (ø)
atoma-p2p/src/tests.rs 98.99% <98.99%> (ø)
atoma-p2p/src/service.rs 0.00% <0.00%> (ø)
atoma-p2p/src/utils.rs 29.54% <29.54%> (ø)
atoma-p2p/src/metrics.rs 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@maschad maschad marked this pull request as ready for review February 23, 2025 04:10
@maschad maschad requested a review from Cifko February 23, 2025 04:10
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Left a few minor comments, let's address these and then merge it

@maschad maschad merged commit 04c4395 into atoma-network:main Feb 23, 2025
7 checks passed
@maschad maschad deleted the mc/feat/add-p2p-metrics branch February 23, 2025 22:33
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track Gossipsub and libp2p metrics Track bandwidth of a Node
3 participants