Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add signature verification to node response #105

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

jorgeantonio21
Copy link
Contributor

No description provided.

@jorgeantonio21 jorgeantonio21 added the enhancement New feature or request label Jan 1, 2025
@jorgeantonio21 jorgeantonio21 requested a review from Cifko January 1, 2025 12:08
@jorgeantonio21 jorgeantonio21 self-assigned this Jan 1, 2025
@maschad maschad self-assigned this Feb 10, 2025
@maschad maschad marked this pull request as ready for review February 10, 2025 18:35
Copy link
Contributor Author

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -36,6 +36,23 @@ jobs:
- name: cargo format
run: cargo fmt --all -- --check

toml-format:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some formatting for our .toml files

Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off on merging this until #219 is merged, we will also want to see the impact of blocking on the stream and the e2e tests are functional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants