fix: fixed forced workspace mode enablement #2565
Open
+61
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamburus
force-pushed
the
feature/workspaces
branch
2 times, most recently
from
c42c1be to
548c919
Compare
pamburus
force-pushed
the
feature/workspaces
branch
from
548c919 to
693c992
Compare
pamburus
commented
Jan 28, 2025
| @@ -788,10 +834,6 @@ impl Settings { | |||
| .set_default("daemon.socket_path", socket_path.to_str())? | |||
| .set_default("daemon.systemd_socket", false)? | |||
| .set_default("daemon.tcp_port", 8889)? | |||
| .set_default( | |||
There was a problem hiding this comment.
I am not sure about this change.
I noticed duplicate defaults for many parameters here and didn't understand the purpose.
|
This pull request has been mentioned on Atuin Community. There might be relevant details there: https://forum.atuin.sh/t/changes-in-behaviour-in-18-4-vs-18-3-left-key-to-exit-workspaces/769/7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
This pull request fixes backward compatibility break introduced in #2430.