-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Deezer v7 #95
base: master
Are you sure you want to change the base?
Conversation
Some patches fail to be applied when node_modules are not already installed. Skipping patches for now.. |
Output of vainfo: $ vainfo
libva info: VA-API version 1.20.0
libva info: User environment variable requested driver 'iHD'
libva info: Trying to open /usr/lib/x86_64-linux-gnu/dri/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_20
libva info: va_openDriver() returns 0
vainfo: VA-API version: 1.20 (libva 2.12.0)
vainfo: Driver version: Intel iHD driver for Intel(R) Gen Graphics - 24.1.0 () |
MVP: it works! 🥳 Now, I will bring back the necessary plugins - some of them are useless I believe (smn double check please) |
(@aunetx) @randshell @asyd could you review? Also, this deprecates any work on v6.x.x |
@josselinonduty thanks for the PR! Mind to test if MPRIS is working fine? (you can test with |
I checked it was working based on the mpris desktop 'notification' (on ubuntu 24 / gnome 46 there is a persistent notification displaying the current track as well as the controls). Anyway, here is the output of signal time=<timestamp> sender=:1.197 -> destination=(null destination) serial=10658 path=/org/mpris/MediaPlayer2; interface=org.freedesktop.DBus.Properties; member=PropertiesChanged
string "org.mpris.MediaPlayer2.Player"
array [
dict entry(
string "Metadata"
variant array [
dict entry(
string "mpris:artUrl"
variant string "file:///tmp/.org.chromium.Chromium.<uid>"
)
dict entry(
string "mpris:length"
variant int64 199000000
)
dict entry(
string "mpris:trackid"
variant object path "/org/chromium/MediaPlayer2/TrackList/<trackid>"
)
dict entry(
string "xesam:album"
variant string "<album>"
)
dict entry(
string "xesam:artist"
variant array [
string "<artist>"
]
)
dict entry(
string "xesam:title"
variant string "<title>"
)
]
)
] |
the Thanks for your work! |
What do you expect the url to look like? |
Greetings I was able to build and run this on fedora. The discord rpc, mpris all worked for me. The ArtUrl is just an url linking to a image. Your file shows a path on your computer. It is correct on my end though. I made a patch that is probably not worth mentioning (I could not apply the patches without adding --fuzz and fixed some semantics):
Edit: the markdown formatting is killing me 😠 |
Something like:
|
Good idea! However, why would you create a patch for that?
I believe that fuzzing can be somehow unreliable, so I personally advocate a real script update especially for a major release. |
@josselinonduty stupid question, how do you patch it on your pc? I think it creates the package.json and lockfile dynamically when running make install_deps. Also I messed up, because of markdown the ` disappeared. They should all be removed since it results into an error.
|
Edit: Actually, I read your message too quickly. I thought you wanted to change Deezer's deps after install_deps. Note: I am working on creating some docs and scripts to make patching more clear and easy. |
Co-Authored-By: Meincrakker <50109822+Meincrakker@users.noreply.github.com>
Alright, I would argue that In fact, I checked the changelog for electron v32 -> v33. They updated V8 engine to v13.0.0 which must have broken the api used by There are 3 solutions for me:
I don't think solution 1 would be a good idea. I'd go for 3 (for now), but I figured out @asyd really loves mpris ;) (I agree it is nice to control deezer from cli and such) so you may want to fork and update abstract-worker/mpris-service if it is reasonable. |
Anyone using arm64 by any chance? |
I removed support for snap because of AppArmor restrictions and refactored the docs. Added contributing guidelines and good practices. |
…lback release to `1.0.0`
| ----------------------- | ----------------------------------------------------------------------------------------------- | | ||
| `--start-in-tray` | Start the app in the tray (see [patch](./patches/01-start-hidden-in-tray.patch)) | | ||
| `--disable-systray` | Quit the app when the window is closed (see [patch](./patches/03-quit.patch)) | | ||
| `--disable-features` | Disable some features (see [patch](./patches/06-better-management-of-MPRIS.patch)) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no implementation of this arg.
Compared to Discord RPC, this one is ok as opt-out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used in patches/06-better-management-of-MPRIS.patch
, at the end of the patch. I am not sure I understood this switch well enough though, could you explain it ?
Hi! I gave this MR an initial read and left some comments. Other than what I wrote there, I'd like to add if we can add a short line inside the new patches to reference the original author? This is already Git, which keeps track of this aspect, but in my opinion it'd be a more appropriate way to maintain their credits. Something along the lines of:
What do you all think? |
I could also redact the author from the file content, to keep all non-source related stuff in git metadata (like any git repo would do). What do you think? |
discord rpc; update rich-presence-builder; make discord rpc opt-in
b745827: discord rich presence is now opt-in by default. Also, I dug around and found more metadata. I've added duration and track url to mpris and discord rich presence. Note: I did not find any information in relation to position. seek, position for mpris, and exact track position for discord rpc cannot be implemented (unless I skipped sth). |
…ed on remove isDev patch
Bumps deezer version to 7.x.x.
Removed: isDev (was included in updated codebase), AutoUpdater[1]
Closes #94
[1]: AutoUpdater might be fixable. We need to find a "platformVersion" variable that is used by semver/autoupdater, and then fake an api call (
https://www.deezer.com/desktop/update?userId=1234¤tVersion=7.0.1&architecture=x64&platform=win32&platformVersion=<???>
). However, since we only update the linux port through github/flatpak/anything but deezer, I think we do not care about this. Please let me know if you disagree.