Update TxPool base fee prior to filtering txs based on effective tip #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
reviewed
Jan 29, 2024
…efee-on-blockbuild
ceyonur
approved these changes
Jan 30, 2024
marun
approved these changes
Jan 30, 2024
Was there another proposal that contained a race condition? |
24a0c34 was the original fix which has a race condition with the periodic updater changing the base fee. I think it's better that this is more accurate even if it messes up the code a little to thread through this parameter. |
oxbee
pushed a commit
to taurusgroup/coreth
that referenced
this pull request
Nov 6, 2024
…va-labs#477) * Update TxPool base fee prior to filtering txs based on effective tip * alt. fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This change allows transactions that have used a base fee that is less than the last fee update's estimate but greater than the actual built block's fee to be included in the block.
This is particularly useful when the base fee is decreasing (with time) and the client is using an estimate that is based on the current time, but the periodic update has not taken effect yet.
How this works
Sets the value used to filter txs before filtering them
How this was tested
CI