fix(core/evm): set difficulty post shanghai to 0 #832
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
approved these changes
Feb 25, 2025
ceyonur
reviewed
Feb 26, 2025
| @@ -65,7 +65,7 @@ func (hooks) OverrideNewEVMArgs(args *vm.NewEVMArgs) *vm.NewEVMArgs { | |||
| if rules.IsShanghai { | |||
| args.BlockContext.Random = new(common.Hash) | |||
| args.BlockContext.Random.SetBytes(args.BlockContext.Difficulty.Bytes()) | |||
| args.BlockContext.Difficulty = nil | |||
| args.BlockContext.Difficulty = new(big.Int) | |||
There was a problem hiding this comment.
aren't we expecting this to be 1 here?
There was a problem hiding this comment.
in the header yes, but not in the block context, which is the handoff point to the EVM interpreter.
The interpreter will start using the "Random" opcode post shanghai, which will read the value of "Random"
The value of Difficulty will actually be unused (Which is how this was previously working), but I still figure it's better to set it the same way as upstream.
ARR4N
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Seems post merge difficulty is set to 0 not nil https://github.com/ava-labs/libevm/blob/main/core/evm.go#L71
If you copy a header with nil difficulty, you end up with a header with difficulty 0.
So seems we should fix this.
How this works
Changes nil to 0
How this was tested
CI
Need to be documented?
No
Need to update RELEASES.md?
No