patch up master merge (takes 94dca86) + refactor customheaders #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
commented
Feb 27, 2025
darioush
commented
Feb 27, 2025
darioush
commented
Feb 27, 2025
| newConfig := *c | ||
| set(&newConfig) | ||
| return &newConfig | ||
| } |
There was a problem hiding this comment.
I think this style reads nicer but feel free to put it back
There was a problem hiding this comment.
Fine with me, I just moved it to a "normal" function instead of being a global var which is a bit strange-ish.
clone header
darioush
force-pushed
the
darioush/libevm-master-merge
branch
from
67aa412 to
a82c6be
Compare
qdm12
force-pushed
the
qdm12/libevm-master-merge
branch
from
1cfe453 to
0097caa
Compare
|
I incorporated the changes in the merge commits of #828 given we need to merge commit this branch into libevm, to keep a cleaner history. I managed to split it in minimal requirements per merge commit to make CI pass, but overall it's all integrated in there. |
|
Closing this in favor of #828 Relevant commits where this is incorporated (no link/commit hash due to future rebases)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
may want to review & merge 1st commit separately