[ALS-1839] Route avoidance options #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ute box border issue
…lized lng when map renders world copies
…ct/amazon-location-features-demo-web into ALS-1839_more-route-options
…3/makeen-project/amazon-location-features-demo-web into ALS-1839_more-route-options
[ALS-1839] Route avoidance options
[ALS-1839] Route avoidance options
src/locales/en/en.json
Outdated
| "text": "Avoid dirt roads" | ||
| }, | ||
| "avoid_uturns": { | ||
| "text": "Avoid uTurns" |
There was a problem hiding this comment.
We should probably display it as "U-turns" instead of "uTurns" since "uTurn" is the value for it for HERE's API, but it is referred to as a "U-turn" in real life
There was a problem hiding this comment.
I agree with this suggestion. Can we get a follow up PR to update the strings for all languages to be in the U-Turn format?
| Ferries: routeOptions.avoidFerries, | ||
| DirtRoads: routeOptions.avoidDirtRoads, | ||
| Tunnels: routeOptions.avoidTunnels, | ||
| ...uturnAvoidanceOption |
There was a problem hiding this comment.
Any reason why we aren't supporting other avoidance options?
"CarShuttleTrains": boolean,
"ControlledAccessHighways": boolean,
"DirtRoads": boolean,
"Ferries": boolean,
"SeasonalClosure": boolean,
"TollRoads": boolean,
"TollTransponders": boolean,
"TruckRoadTypes": [ "string" ],
"Tunnels": boolean,
"UTurns": boolean,
https://docs.aws.amazon.com/location/latest/APIReference/API_CalculateRoutes.html
There was a problem hiding this comment.
Discussed offline that this is the set of avoidance options we want to go with as a starting point.
shashankj-aws
approved these changes
Feb 3, 2025
imraymondlee
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds routes avoidance options for all the travel modes; including Tolls, Farries, Dirtroad, UTurns and Tunnels. uTurn avoidance is not supported for Pedestrian and Scooter travel modes. Also adds new avoidance options in default settings.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.