Skip to content

Commit

Permalink
update checkov suppressions
Browse files Browse the repository at this point in the history
  • Loading branch information
novekm committed Jul 14, 2024
1 parent 1818e68 commit 534eda9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
6 changes: 1 addition & 5 deletions .config/.checkov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ skip-check:
- CKV2_AWS_12 # Ensure the default security group of every VPC restricts all traffic
- CKV2_AWS_20 # Ensure that ALB redirects HTTP requests into HTTPS ones
- CKV2_AWS_32 # Ensure CloudFront distribution has a response headers policy attached
# - CKV_AWS_260 # Ensure no security groups allow ingress from 0.0.0.0:0 to port 80
- CKV_AWS_65 # Ensure container insights are enabled on ECS cluster
- CKV_AWS_333 # Ensure ECS services do not have public IP addresses assigned to them automatically
- CKV_AWS_158 # Ensure that CloudWatch Log Group is encrypted by KMS
Expand All @@ -35,10 +34,7 @@ skip-check:
- CKV_AWS_174 # Verify CloudFront Distribution Viewer Certificate is using TLS v1.2
- CKV_AWS_305 # Ensure CloudFront distribution has a default root object configured
- CKV_AWS_219 # Ensure CodePipeline Artifact store is using a KMS CMK
- CKV_AWS_314 # Ensure CodeBuild project environments have a logging configuration"
- CKV_AWS_111 # Ensure IAM policies does not allow write access without constraints
- CKV_AWS_109 # Ensure IAM policies does not allow permissions management / resource exposure without constraints
- CKV_AWS_356 # Ensure no IAM policies documents allow "*" as a statement's resource for restrictable actions
- CKV_AWS_314 # Ensure CodeBuild project environments have a logging configuration
- CKV2_AWS_6 # Ensure that S3 bucket has a Public Access block
- CKV2_AWS_61 # Ensure that an S3 bucket has a lifecycle configuration
- CKV2_AWS_62 # Ensure S3 buckets should have event notifications enabled
Expand Down
6 changes: 3 additions & 3 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -1156,11 +1156,13 @@ resource "aws_iam_policy" "streamlit_codepipeline_policy" {

# CodeBuild
data "aws_iam_policy_document" "streamlit_codebuild_policy" {
#checkov:skip=CKV_AWS_111:Ensure IAM policies does not allow write access without constraints
#checkov:skip=CKV_AWS_109:Ensure IAM policies does not allow permissions management / resource exposure without constraints
#checkov:skip=CKV_AWS_356:Ensure no IAM policies documents allow "*" as a statement's resource for restrictable actions
# S3 Allow
statement {
effect = "Allow"
actions = [
# "s3:*",
"s3:GetObject",
"s3:GetObjectVersion",
"s3:GetBucketVersioning",
Expand Down Expand Up @@ -1201,8 +1203,6 @@ data "aws_iam_policy_document" "streamlit_codebuild_policy" {
"logs:PutLogEvents"
]
resources = [
# aws_cloudwatch_log_group.streamlit_ecs_service_log_group.arn
# "arn:aws:logs:${data.aws_region.current.name}${data.aws_caller_identity.current.account_id}:log-group:/aws/codebuild/${var.app_name}-image-builder:log-stream:*"
"*",
"arn:aws:logs:${data.aws_region.current.name}${data.aws_caller_identity.current.account_id}:log-group:/aws/codebuild/${var.app_name}-image-builder:log-stream:*"
]
Expand Down

0 comments on commit 534eda9

Please sign in to comment.