remove pDataset/pPipeline/pStage parameters #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pDatasetName, pDeploymentInstance and pS3Prefix have a similar purpose, and it is confusing to keep all three. Start by removing pDatasetName.
pPipeline and pStageName, and pDeploymentInstance have a similar purpose
pPipeline and pStageName, and pDeploymentInstance have a similar purpose
pPipeline and pStageName, and pDeploymentInstance have a similar purpose
pPipeline and pStageName, and pDeploymentInstance have a similar purpose
it was wrongly used in place of pBucketPrefix and unnecessarily used in resource names
it was wrongly used in place of pBucketPrefix and unnecessarily used in resource names
pPipelineName and pStageName, and pDeploymentInstance have a similar purpose
pPipelineName and pStageName, and pDeploymentInstance have a similar purpose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Better handle sdlf-dataset S3 prefix and rationalise use of pDataset/pPipeline/pStage parameters
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.