Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing unit tests #164

Merged
merged 1 commit into from
Feb 7, 2025
Merged

chore: add missing unit tests #164

merged 1 commit into from
Feb 7, 2025

Conversation

drduhe
Copy link
Collaborator

@drduhe drduhe commented Feb 5, 2025

Issue #, if available: n/a

Notes

  1. Unit Tests:
  • This PR adds comprehensive unit tests for the following configuration modules:
    • BaseConfig: Ensures proper initialization, default values, and dynamic property assignments.
    • RegionalConfig: Tests region-specific configurations and default fallback behavior.

2.Fixing Linting:

  • Removed broken line - allowShortCircuit: true in .eslintrc.yaml

3.Updating index.ts:

  • Adding export for regional_config

Checklist

Before you submit a pull request, please make sure you have the following:

  • Code changes are compact and well-structured to facilitate easy review
  • Changes are documented in the README.md and other relevant documentation pages
  • PR title and description accurately reflect the changes and are detailed enough for historical tracking
  • PR contains tests that cover all new code and the code has been manual tested
  • All new dependencies are declared (if any), and no unnecessary libraries are added
  • Performance impacts (if any) of the changes are evaluated and documented
  • Security implications of the changes (if any) are reviewed and addressed
  • I have read the Contributing Guidelines and agree to follow the Code of Conduct

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

github-actions bot commented Feb 5, 2025

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
90.68% (+0.01% 🔼)
623/687
🔴 Branches
57.14% (+0.57% 🔼)
100/175
🟢 Functions 96.3% 52/54
🟢 Lines
90.68% (+0.01% 🔼)
623/687

Test suite run success

35 tests passing in 16 suites.

Report generated by 🧪jest coverage report action from 4a88109

@drduhe drduhe merged commit 6b65d05 into main Feb 7, 2025
2 checks passed
@drduhe drduhe deleted the chore/add-unit-tests branch February 7, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants