Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MROutstandingImageJobsTable to MRDataplane #165

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

edparris
Copy link
Contributor

@edparris edparris commented Feb 13, 2025

This change adds a new DynamoDB table to the ModelRunner dataplane construct. This new table is for use by future job scheduler implementations that need to keep a record of requests pulled from the SQS queue that have not yet been started. Changes include creation of the table and passing of the table's name into the ModelRunner application via a environment variable in the ECS task configuration.

Unit tests were updated and changes were manually verified by deploying a new stack and confirming that the table and environment were updated as expected.

Checklist

Before you submit a pull request, please make sure you have the following:

  • Code changes are compact and well-structured to facilitate easy review
  • Changes are documented in the README.md and other relevant documentation pages
  • PR title and description accurately reflect the changes and are detailed enough for historical tracking
  • PR contains tests that cover all new code and the code has been manual tested
  • All new dependencies are declared (if any), and no unnecessary libraries are added
  • Performance impacts (if any) of the changes are evaluated and documented
  • Security implications of the changes (if any) are reviewed and addressed
  • I have read the Contributing Guidelines and agree to follow the Code of Conduct

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

github-actions bot commented Feb 13, 2025

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
90.7% (+0.01% 🔼)
624/688
🔴 Branches 57.14% 100/175
🟢 Functions 96.3% 52/54
🟢 Lines
90.7% (+0.01% 🔼)
624/688

Test suite run success

35 tests passing in 16 suites.

Report generated by 🧪jest coverage report action from 22cb0f3

@edparris edparris force-pushed the feature/mr-outstanding-jobs-table branch from 9a58f2b to 22cb0f3 Compare February 13, 2025 18:18
Copy link
Collaborator

@drduhe drduhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus the one comment.

* The name of the DynamoDB table for outstanding image jobs.
* @default "OutstandingImageProcessingJobs"
*/
public DDB_OUTSTANDING_IMAGE_JOBS_TABLE: string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might keep the naming standard with what we call it in the model runner package for symmetry with how we do it for the other tables.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a suggested name? I don't really see a consistent convention among these DDB table names and don't really care what we call this in the CDK.

DDB_ENDPOINT_PROCESSING_TABLE -> EndpointProcessingStatistics -> endpoint_statistics_table.py
DDB_FEATURES_TABLE -> ImageProcessingFeatures -> feature_table.py
DDB_JOB_STATUS_TABLE -> ImageProcessingJobStatus -> job_table.py
DDB_REGION_REQUEST_TABLE -> RegionProcessingJobStatus -> region_request_table.py

Copy link
Collaborator

@drduhe drduhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edparris edparris merged commit ea4f516 into main Feb 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants