-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add MROutstandingImageJobsTable to MRDataplane #165
Conversation
Coverage report
Test suite run success35 tests passing in 16 suites. Report generated by 🧪jest coverage report action from 22cb0f3 |
9a58f2b
to
22cb0f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM minus the one comment.
* The name of the DynamoDB table for outstanding image jobs. | ||
* @default "OutstandingImageProcessingJobs" | ||
*/ | ||
public DDB_OUTSTANDING_IMAGE_JOBS_TABLE: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might keep the naming standard with what we call it in the model runner package for symmetry with how we do it for the other tables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a suggested name? I don't really see a consistent convention among these DDB table names and don't really care what we call this in the CDK.
DDB_ENDPOINT_PROCESSING_TABLE -> EndpointProcessingStatistics -> endpoint_statistics_table.py
DDB_FEATURES_TABLE -> ImageProcessingFeatures -> feature_table.py
DDB_JOB_STATUS_TABLE -> ImageProcessingJobStatus -> job_table.py
DDB_REGION_REQUEST_TABLE -> RegionProcessingJobStatus -> region_request_table.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change adds a new DynamoDB table to the ModelRunner dataplane construct. This new table is for use by future job scheduler implementations that need to keep a record of requests pulled from the SQS queue that have not yet been started. Changes include creation of the table and passing of the table's name into the ModelRunner application via a environment variable in the ECS task configuration.
Unit tests were updated and changes were manually verified by deploying a new stack and confirming that the table and environment were updated as expected.
Checklist
Before you submit a pull request, please make sure you have the following:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.