run pre-commit on s3transfer

[kdaily]

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[aemous]

a couple small requested changes.

One overarching concern I have is, will some of these cause us to deviate from boto/s3transfer? Do we want to match our formatting options to be identical to the ones used in that repo? For whitespaces it may not be a big deal, but for reordering imports and swapping interchangeable exceptions I wonder if this becomes a concern

[aemous]

nit: rename to test_non_seekable_oserror since we're switching to raise OSError here

non-blocking.

[aemous]

should be worth (and safe) swapping this IoError for oserror too. And also renaming to reflect this

[kdaily]

Sure; raising an IOError or OSError result in identical behavior.

>>> try:
...     raise OSError
... except IOError:
...     print("hooray")
...
...
hooray
>>> try:
...     raise IOError
... except OSError:
...     print("hooray")
...
...
hooray

[aemous]

I agree, I just figured if we're replacing the deprecated IOError in line 332, that we may as well also do a similar swap on 333.

I understand they're functionally equivalent.

Also non-blocking, feel free to resolve if you disagree

[kdaily]

Regarding socket.error to OSError:

https://docs.astral.sh/ruff/rules/os-error-alias/

Also, just to check its really an alias (confirmed this back to Python 3.8):

>>> import socket
>>> raise socket.error
Traceback (most recent call last):
  File "<input>", line 1, in <module>
    raise socket.error
OSError

[kdaily]

will some of these cause us to deviate from boto/s3transfer

In the short term, yes, only because we enabled Ruff to do the import sorting (instead of isort). Offline discussions resulted in us going ahead with the more modern approach and the boto repositories (botocore and s3transfer) will catch up. For botocore, there is already a customer PR to modernize import sorting:

boto/botocore#3380

See discussion when enabling ruff import sorting on the CLI repository here:

• Add precommit for linting and formatting #9123 (comment)
• Add precommit for linting and formatting #9123 (comment)

[kdaily]

Force-pushed to pull in latest v2 changes, required for running internal build.

[aemous]

LGTM. Have a couple non-blocking unresolved comments if you agree with them, otherwise I'm good with merging this