fix: Adding interopt testing from JS for the Hierarchical Keyring #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ESDK-JS has a KDF-CTR implementation. These are additional test vectors.
seebees
force-pushed
the
seebees/esdk-js-h-keyring-interopt-vectors
branch
from
52b993d to
bc5541b
Compare
|
Detected changes to the release files or to the check-files action |
|
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
texastony
reviewed
Feb 12, 2025
| // that JS and Dafny are testing the same test vectors. | ||
| // I only use okm because there is a deterministic relationship | ||
| // between all inputs and the okm. | ||
| const vectorOkmDigest: seq<uint8> := [ |
There was a problem hiding this comment.
It's probably cleaner to embedded these digests into the test vectors as an additional member/field.
Otherwise, if we change one p, we need to update this list as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are additional test vectors from the ESDK-JS
that support the Hierarchical Keyring.
Both tests vectors for KDF CTR and the keyring itself.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.