chore: make EncodeAscii ghost

[ajewellamz]

Issue #, if available:

Description of changes:

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[texastony]

LGTM, but know that I'm concerned changing EncodeAscii will effect ESDK/DB-ESDK.

However, I'm a little confused, as I actually did not see a change to EncodeAscii, just changes at its various call sites?

[ajewellamz]

LGTM, but know that I'm concerned changing EncodeAscii will effect ESDK/DB-ESDK.

However, I'm a little confused, as I actually did not see a change to EncodeAscii, just changes at its various call sites?

The behavior of EncodeAscii did not change.
The only code change was to add the word ghost

The point of call changes went from

const KMS_ECDH_PROVIDER_ID: UTF8.ValidUTF8Bytes := UTF8.EncodeAscii("aws-kms-ecdh")

to

const KMS_ECDH_PROVIDER_ID: UTF8.ValidUTF8Bytes :=
    var s := [0x61, 0x77, 0x73, 0x2d, 0x6b, 0x6d, 0x73, 0x2d, 0x65, 0x63, 0x64, 0x68];
    assert s == UTF8.EncodeAscii("aws-kms-ecdh");
    s

That is, explicit bytes, with an assert that nothing changed.

[github-actions]

Detected changes to the release files or to the check-files action

[github-actions]

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS