Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update releaserc #1312

Merged
merged 21 commits into from
Feb 12, 2025
Merged

chore: update releaserc #1312

merged 21 commits into from
Feb 12, 2025
+225 −4

Conversation

josecorella
Copy link
Contributor

@josecorella josecorella commented Feb 11, 2025 •
edited
Loading

Issue #, if available:

Description of changes:

The current rules will produce a changelog like this:

## 1.10.0 (https://github.com/aws/aws-cryptographic-material-providers-library/compare/v1.9.0...v1.10.0) (2025-02-12)

### Features -- All Languages

    * dafny: a test (a88bbeb (https://github.com/aws/aws-cryptographic-material-providers-library/commit/a88bbeb104c23d03463d4f1a2a5a5603dc4fdd9a))

### Features -- Java

    * java: a test (28f0c81 (https://github.com/aws/aws-cryptographic-material-providers-library/commit/28f0c819baeddb05b95482b9f54667ca401844cf))

### Features -- DotNet

    * dotnet: a test (dc4dde0 (https://github.com/aws/aws-cryptographic-material-providers-library/commit/dc4dde088806e60734298ecc4afe0dcb8f0e5d18))

### Features -- Python

    * python: a test (68e8152 (https://github.com/aws/aws-cryptographic-material-providers-library/commit/68e815245de10de40c6622c194328d39b9892ca0))

### Features -- Go

    * go: a test (50f8b39 (https://github.com/aws/aws-cryptographic-material-providers-library/commit/50f8b393d485874a332f4dd459d72d2b45c3d00a))

### Features -- Rust

    * rust: a test (1dff9e0 (https://github.com/aws/aws-cryptographic-material-providers-library/commit/1dff9e0cddb4517a700fbda56e49652bd0686c95))
    * rust: a test (e7e5e05 (https://github.com/aws/aws-cryptographic-material-providers-library/commit/e7e5e05cd9ffb49a375870f290aeae8779cef67e))

### Maintenance -- All Languages

    * dafny: format dafny code with latest formatter (c4f3bbe (https://github.com/aws/aws-cryptographic-material-providers-library/commit/c4f3bbe44c2dcb4061e5f3babdc79b0a669c24c2))

### Miscellaneous

    * ci: update gihub workflows (1857979 (https://github.com/aws/aws-cryptographic-material-providers-library/commit/1857979990f98064deafcbf55f7f8768785f6ca0))
    * Enable local testing (#1282 (https://github.com/aws/aws-cryptographic-material-providers-library/issues/1282)) (70e5809 (https://github.com/aws/aws-cryptographic-material-providers-library/commit/70e580991678387ce897a286c4f7f449aa616785))
    * expand prettier ignore (#1270 (https://github.com/aws/aws-cryptographic-material-providers-library/issues/1270)) (094c01c (https://github.com/aws/aws-cryptographic-material-providers-library/commit/094c01cf9826a7cff22d258faedc33da0f9dd01e))
    * update change log rules (5186dd6 (https://github.com/aws/aws-cryptographic-material-providers-library/commit/5186dd6e228452938bc5566cdb856cfa180115cf))

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@josecorella josecorella marked this pull request as ready for review February 11, 2025 23:29
@josecorella josecorella requested a review from a team as a code owner February 11, 2025 23:29
@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

texastony
texastony previously approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!
Have we tested it yet?

@josecorella
Copy link
Contributor Author

This looks great! Have we tested it yet?

I have. I wanted to demo it to the team before merging it in case we wanted any change.

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

lucasmcdonald3
lucasmcdonald3 reviewed Feb 12, 2025
View reviewed changes
.releaserc.cjs Outdated
{
type: "chore",
scope: "dafny",
section: "Maintenance -- Dafny",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be "All Languages"? (I could go either way, sometimes it really isn't for all languages). Ditto for other Dafny scopes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

lucasmcdonald3
lucasmcdonald3 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@josecorella josecorella merged commit 1a43584 into main Feb 12, 2025
197 checks passed
@josecorella josecorella deleted the jocorell/update-releaserc branch February 12, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texastony texastony texastony approved these changes

@lucasmcdonald3 lucasmcdonald3 lucasmcdonald3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josecorella @texastony @lucasmcdonald3