-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3 #38
Conversation
@jordan-brough FYI |
I plan to set a higher minimum version of Ruby and do massive code clean ups, but in the interest of doing this in chunks, this change specifically aligns both the internal package and the public package. @briensea @trivenay FYI - The one file that remains different is the Makefile because of brazil path. Let's talk offline. |
@@ -15,6 +15,6 @@ jobs: | |||
- name: Set up ruby | |||
uses: ruby/setup-ruby@v1 | |||
with: | |||
ruby-version: 2.7 | |||
ruby-version: 3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason to use 3.1 over 3.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was what was internal. My focus here was to do the syncing and do incremental upgrades on top later. I also wanted to discuss a release strategy. Typically ruby gems support multiple versions of ruby like this gem seemed to do. I think for lambdas use case, it may be simpler to release minor versions corresponding to the ruby version and support a singular ruby minor version. E.g. gem version 3.4 supports ruby 3.4 only. This may work for lambda because you deploy a single ruby version runtime using this gem correct?
Issue #, if available:
First of many PRs to address customer issues and modernize the code.
Description of changes:
This PR syncs the internal LambdaRubyRIC package code with the public GitHub. The intent will be for the public gem to be eventually re-imported back internally and used with the runtime.
I also deleted CentOS because I could not get it to work - it's actually just deprecated and the image does not exist anymore. The mirrorlist has been removed.
Makefile test-unit, test-integ, and test-smoke will pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.